[ https://issues.apache.org/jira/browse/STDCXX-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548479 ]
Martin Sebor commented on STDCXX-676: ------------------------------------- A couple of comments/questions: First, should the code be guarded with _WIN32 or _MSC_VER? I.e., is the limitation specific to Windows the OS (i.e., it affects CygWin), or just to the MSVC runtime library (and has no impact on CygWin)? Second, the description mentions the %T, %e, and %G directives but the patch replaces strftime() directives that surely must be supported even on Windows. It seems we should replace it only for those that have problems. > [MSVC] 22.locale.time.put test fails > ------------------------------------ > > Key: STDCXX-676 > URL: https://issues.apache.org/jira/browse/STDCXX-676 > Project: C++ Standard Library > Issue Type: Bug > Components: Tests > Affects Versions: 4.2.0 > Reporter: Travis Vitek > Fix For: 4.2.1 > > Attachments: stdcxx-223.patch > > > In my manual runs I have noticed that the test fails because the MSCRT > strftime doesn't support %T, %e, or %G and asserts internally. This doesn't > appear to happen on all configurations because these tests are running to > completion on some of the nightly builds. > I think the rw_strftime() that is inside the test could be expanded to avoid > the assert inside the CRT so that the test would pass on all windows > configurations. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.