[
https://issues.apache.org/jira/browse/STDCXX-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551846
]
Martin Sebor commented on STDCXX-459:
-------------------------------------
The patch looks good to me in general but I have a few compatibility concerns
with it:
1. It removes _RWSTD_EXPORT from __rw::__rw_get_timepunct(). Is this forward
binary compatible on Windows?
2. It adds a new function, __rw::__rw_get_dateorder(). Is this forward binary
compatible?
3. It outlines the virtual member function time_get::do_date_order(). Is this
binary compatible?
> time_get::date_order() should return actually date order taken from locale
> --------------------------------------------------------------------------
>
> Key: STDCXX-459
> URL: https://issues.apache.org/jira/browse/STDCXX-459
> Project: C++ Standard Library
> Issue Type: Improvement
> Components: 22. Localization
> Affects Versions: 4.1.2, 4.1.3, 4.1.4
> Environment: All
> Reporter: Farid Zaripov
> Assignee: Farid Zaripov
> Priority: Minor
> Fix For: 4.2.1
>
> Attachments: stdcxx-459.patch
>
>
> The current implementation of the time_get::date_order() always returns
> no_order. It should return date order used by a locale facet
> (http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg03734.html).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
