On Mon, Mar 14, 2011 at 6:09 PM, rusirius <[email protected]> wrote: > > I believe that the code for my Gps Locator plugin is now just about > complete and will allow any serial GPS device (or USB device presenting > on a COM or /ttyUSB port) sending NMEA sentences to be used to provide > position data to Stellarium. I have tested on Windows and Ubuntu Linux > but it still needs testing on a Mac. Can you advise me what the next > step is please? Should I now request a merge?
The good news is that I found out how to merge two unrelated Bazaar branches, so the way the branch was created will not be a problem for merging it into the trunk (just don't use the standard merge proposal mechanism). The bad news: - your branch throws an exception in the destructor of the GPS class when the plug-in is de-initialized. Looking at it reveals that you are trying to deallocate an array. Please remove it, as arrays as a type are automatically deallocated. - your code is breaking *both* C++'s common coding conventions and Stellarium's preferred coding style. For example, function names should not begin with a capital letter. See http://www.stellarium.org/doc/head/codingStyle.html Some other points: - I think it's a good idea to mention the NMEA standard explicitly in the description of the plug-in. - The button image is ugly and doesn't blend with the rest of the icons. I think that a simple, one color image (for example, the letters "GPS") would be better than the current one. Regards, Bogdan Marinov ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Stellarium-pubdevel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
