Hi all,
I think the branch
(lp:~stellarium/stellarium/simplegles-qml-noqaction) is ready to be
merged into the trunk now. If there are some remaining issues, they
can probably be worked on at the same time as the Qt5 branch merge. I
plan to merge sometime this week, so let me know if there is something
that you think should postpone the merge.
Regards,
guillaume
On Mon, Sep 23, 2013 at 6:11 PM, Guillaume Chéreau
<guillaume.cher...@gmail.com> wrote:
> On Mon, Sep 23, 2013 at 3:18 PM, Barry Gerdes <barrygas...@hotmail.com> wrote:
>> Hi Gui
>> The current build of simplegles-qml-noqaction now works after that merge you
>> did
>> Now that I have it running what would you like me to check out.
>
> Hi Barry: you can check my last few commits in this branch, it deals
> with the saving of the shortcuts in the config.ini file. So far I
> think this is nice like that, because using the global QSettings
> instance is simple and makes the code small. But there might be some
> corner cases that I didn't think of.
>
> If you want you can also check the StelActionMgr.hpp file. This is
> more or less a clone of the previous StelShortcutMgr using StelAction
> instead of QAction. See all the changes I made in the different
> modules that shows how we register actions.
>
> I am quite happy with the automatic connection of actions to slot /
> properties, but then I understand that we need to be careful with this
> kind of tricks, so please let me know if you foresee some problems
> with this approach.
>
> I still need to polish the branch before we can even consider merging
> it ; notably the translation of the action descriptions is probably
> not working, and also I messed with the group names of the actions, so
> in the shortcut editor we can see duplicated groups.
>
> Regards,
>
> gui
>
> --
> Guillaume
> guillaume.cher...@gmail.com
> +886 970422910
--
Guillaume
guillaume.cher...@gmail.com
+886 970422910
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
Stellarium-pubdevel mailing list
Stellarium-pubdevel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
