On Tue, Mar 25, 2014 at 2:14 PM, Erik Carstensen <[email protected]> wrote:
> It's easy to implement as long as you require --unapplied, though; see
> attached patch. (the commented-out test fails. It can be revived once the
> push_patch() limitation is lifted)

Looks good, with two exceptions:

  1. It would be prettier to not have the failing test commented out;
     mark it as a known failure instead, with a short comment
     explaining what's amiss.

  2. I'm not convinced that "stg pick" is the right place to put
     this---at least in my ears, "pick" clearly means grabbing
     something and bringing it *to oneself*. But I can't think of a
     better home for it either ("stg dup" or "stg copy"?).

-- 
Karl Wiberg, [email protected]
   subrabbit.wordpress.com
   www.treskal.com/kalle

_______________________________________________
stgit-users mailing list
[email protected]
https://mail.gna.org/listinfo/stgit-users

Reply via email to