On 16 December 2014 at 18:15, Peter Maydell <[email protected]> wrote: > On 23 June 2014 at 23:00, Peter Maydell <[email protected]> wrote: >> The top level Makefile allows the user to specify their Python using >> the PYTHON variable; however the sub-Makefiles weren't honouring this, >> which meant that if you didn't have a 'python2' executable then the >> make 'all' and 'install' targets would work but 'doc' and 'install-doc' >> would not. >> >> Add explicit uses of $(PYTHON) everywhere we run a python script from >> the Makefiles, bringing the sub-makefiles in line with the top level one. >> >> Signed-off-by: Peter Maydell <[email protected]> > >> --- a/t/Makefile >> +++ b/t/Makefile >> @@ -7,7 +7,7 @@ SHELL_PATH ?= $(SHELL) >> TAR ?= $(TAR) >> >> all: >> - python test.py >> + $(PYTHON) test.py > > It's been pointed out to me that this doesn't work when PYTHON > isn't set on the make command line, because make doesn't > export variables to submakes if they're only set by make itself. > That results in the submakes getting an empty "PYTHON" variable, > which happens to work for stg-build &c because they're executable, > but not for test.py, which isn't. > > Easiest fix is to add "export PYTHON". (The fact that > DESTDIR isn't exported also looks odd, but that's a > separate bug I guess.)
I fixed it up directly in your patch and pushed it out. Thanks. -- Catalin _______________________________________________ stgit-users mailing list [email protected] https://mail.gna.org/listinfo/stgit-users
