Avantika, Great start, Here is a list of some comments.
- The Config Configuration Settings should really only include DB connString/user/password - Same for the ConfigConsole App.config - don't include your .sou files in the patches (they fail anyways) - The IDAL, DALFac, DALSql Config.cs and IConfig.cs files were added to the csproj files, but not included in the patch. - Can you describe the use cases for the operations you've setup? I think there still some unnecessary operations in yours. I can think of two different approaches both have only 3 operations. 1. (how PHP does it) Get your own config before any operation, this includes your database info and your next parties endpoint info (getconfig would return db info+bs address) - in this scenario all we need is GetClientConfig, GetBsConfig, GetOpsConfig // ClientConfigResponse GetClientConfig(ClientConfigRequest client) // BsConfigResponse GetBsConfig(BsConfigRequest client) // OpsConfigResponse GetOpsConfig(OpsConfigRequest client) 2. Get the active endpoints or database depending on what you need - in this scenario you'd have GetActiveDb, GetBsForClient, GetOpsForBs // DbConfigResponse GetActiveDb() // EndpointConfigResponse GetBsForClient(string client) // EndpointConfigResponse GetOpsForBs(string bs) To me it comes down to the return type objects, in scenario 1, we need custom inputs/outputs for everything. In scenario 2 we could use common strings, DbConfig, and EndpointConfig objects. Now, this is really the basic level and we need to try to think forward a bit to what we might have with the full new UI. For this ticket I would stick to something along these lines. I'd like to hear your thoughts and any other Use Cases you are planning for. -Ben -----Original Message----- From: Avantika Agrawal (JIRA) [mailto:[email protected]] Sent: Friday, June 12, 2009 3:29 PM To: [email protected] Subject: [jira] Updated: (STONEHENGE-66) Create a .NET Config Service [ https://issues.apache.org/jira/browse/STONEHENGE-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avantika Agrawal updated STONEHENGE-66: --------------------------------------- Attachment: Stonehenge-66.patch Here's what I have so far. You will find a new folder called Config_Service which hs the same structure as the OrderProcessor_Service - it should have a ConfigServiceSolution Also, there are some addtions made to the common folder - an IConfig interface and its implementation. I am sticking with the format of the php. Ben, you may find that I changed your contract very slightly, but this is in line with the php format so I don't think it should be an issue. I have left comments in areas which still need work. Moreover, I have not implemented setActiveDB, getDBConfig, and other methos relating to DB configuration yet - I think we should come to those later, once we have this service up and running. This service builds successfully but it is not running. I am getting a few errors. Will update this when those are fixed, but for now, you guys can take a look at what I've done so far and send me any feedback you may have. > Create a .NET Config Service > ---------------------------- > > Key: STONEHENGE-66 > URL: https://issues.apache.org/jira/browse/STONEHENGE-66 > Project: Stonehenge > Issue Type: New Feature > Reporter: Avantika Agrawal > Priority: Minor > Attachments: Stonehenge-66.patch > > > Implement Ben's ConfigContract to create a configuration service attached to > the .NET Client -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
