Sure, Shankar, I'll check them this monday On Sun, Jun 21, 2009 at 4:02 PM, Selvaratnam Uthaiyashankar < [email protected]> wrote:
> Hi Ming Jin, > > When we moved WSAS (previously Java in contrib) from contrib to trunk, we > fixed lots of issues. Can you check whether the fixes are there in trunk? > If > not, can you create a jira (and possibly provide a patch :D ) ? > > Reards, > Shankar > > On Sun, Jun 21, 2009 at 8:56 AM, Ming Jin <[email protected]> wrote: > > > Hi > > When we implemented the Metro stocktrader, we fixed some bugs in original > > WSAS implementation, especially the components WSAS used to talk to DB. > > > > I don't know whether those bugs have been fixed in WSAS implementation. > If > > not, then we can't simply take the components from WSAS. > > > > We can collect the bugs we fixed this monday, and report to you. > > > > On Sun, Jun 21, 2009 at 11:03 AM, Selvaratnam Uthaiyashankar < > > [email protected]> wrote: > > > > > Hi Ben, > > > > > > If we are refactoring, then changing the namespace might not be needed, > > > because whatever component having wso2 namespace in metro is shared by > > WSAS > > > implementation as well, so we can take the components from WSAS (which > > > already have apache namespace) and put them in the common place. > > > > > > If others are OK, I am completely ok for commiting with the existing > > > namespace and then refactor. > > > > > > Regards, > > > Shankar > > > > > > On Sun, Jun 21, 2009 at 8:00 AM, Ben Dewey <[email protected]> wrote: > > > > > > > Shankar, > > > > > > > > Based on this email, are you saying that the Metro code org.wso2... > > > > namespaces should be renamed to org.apache.. before applying metro to > > the > > > > trunk? Then refactor redundancies later? Or can we apply to trunk > > with > > > > existing namespaces? > > > > > > > > -Ben > > > > > > > > -----Original Message----- > > > > From: Selvaratnam Uthaiyashankar [mailto:[email protected]] > > > > Sent: Tuesday, June 09, 2009 10:30 PM > > > > To: [email protected] > > > > Subject: Re: Moving Metro to trunk > > > > > > > > Hi Kent, > > > > > > > > There are lots of common code shared by WSO2 and Metro > > > > implementations. Once we fix the namespaces, we can easily find the > > > > common code. We can extract them and put it in stocktrader/java > place. > > > > As you said, we don't need to do it before moving to trunk. First we > > > > have to fix the namespaces and commit it to the trunk, then we can > > > > refactor them. > > > > > > > > Regards, > > > > Shankar > > > > > > > > On Tue, Jun 9, 2009 at 10:39 PM, Kent Brown<[email protected] > > > > > > wrote: > > > > > Shankar, > > > > > > > > > > Related to the namespaces, do you have thoughts on how to best > > refactor > > > > things so the WSO2 and Sun Metro can rely as much as possible on > shared > > > > versions, for example of the java code to talk to the database. I > > don't > > > > think this should be required before moving to trunk, but should be > > > looked > > > > at before the next release. > > > > > > > > > > Kent > > > > > > > > > > -----Original Message----- > > > > > From: Selvaratnam Uthaiyashankar [mailto:[email protected]] > > > > > Sent: Tuesday, June 09, 2009 7:08 AM > > > > > To: [email protected] > > > > > Subject: Re: Moving Metro to trunk > > > > > > > > > > Hi Drew, > > > > > > > > > > We might also have to change the namespaces/packages having "wso2" > to > > > > > "apache". "org.wso2.stocktrader" should be changed to > > > > > "org.apache.stonehenge.stocktrader" > > > > > > > > > > Also, there are some *.jar files in the svn. Can we remove them? > > > > > > > > > > Regards, > > > > > Shankar > > > > > > > > > > On Tue, Jun 9, 2009 at 7:11 PM, Drew Baird (Volt)< > > > [email protected]> > > > > wrote: > > > > >> What needs to be done before I move metro? > > > > >> This means from contrib > > > > > > > > > > http://svn.apache.org/repos/asf/incubator/stonehenge/contrib/stocktrader/metro/ > > > > >> to trunk > > > > >> > > > > > > > > > > http://svn.apache.org/repos/asf/incubator/stonehenge/trunk/stocktrader/metro > > > . > > > > >> > > > > >> I have removed the files that do not belong in the tree and I > belive > > > the > > > > next step is to move metro to trunk. > > > > >> > > > > >> The second step would be to have developers test patches > > STONEHENGE-70 > > > > and STONEHENGE-71. Once that is done we can commit the two patches. > > > > >> > > > > >> If no objections I will move the metro to trunk later today. > > > > >> > > > > >> Thanks! > > > > >> Drew > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > > > > > > > > > > > > > > > > > -- > > > > > S.Uthaiyashankar > > > > > Software Architect > > > > > WSO2 Inc. > > > > > http://wso2.com/ - "The Open Source SOA Company" > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > S.Uthaiyashankar > > > > Software Architect > > > > WSO2 Inc. > > > > http://wso2.com/ - "The Open Source SOA Company" > > > > > > > > > > > > > > > > -- > > > S.Uthaiyashankar > > > Software Architect > > > WSO2 Inc. > > > http://wso2.com/ - "The Open Source SOA Company" > > > > > > > > > > > -- > > Ming Jin > > > > Consultant > > Thoughtworks, Inc > > Mobile: +86 135-2125-6300 > > Email: [email protected] > > MSN: [email protected] > > Blog: http://blogjava.net/mingj > > > > > > -- > S.Uthaiyashankar > Software Architect > WSO2 Inc. > http://wso2.com/ - "The Open Source SOA Company" > -- Ming Jin Consultant Thoughtworks, Inc Mobile: +86 135-2125-6300 Email: [email protected] MSN: [email protected] Blog: http://blogjava.net/mingj
