Thanks, Dan -----Original Message----- From: Daniel Kulp [mailto:[email protected]] Sent: Wednesday, July 01, 2009 7:38 AM To: [email protected] Cc: Kamaljit Bath; [email protected] Subject: Re: No committ mail (was RE: [jira] Updated: (STONEHENGE-55) Trying to buy or sell anything an amount larger than 3 digits throws an error in .Net stocktrader)
Actually, the list is/was mis-configured. Commit lists shouldn't require moderation. infra is looking into getting it configured properly. I see Kamal's commit message got "unstuck" and came through. That's a good start. Dan On Wed July 1 2009 10:23:14 am Daniel Kulp wrote: > I was apparently not a moderator for the commit list. I've been added so > if I see something come through, I'll moderate it though. > > BTW: as things progress with Stonehenge, it would probably be good to get > a one or two of you to become moderators instead of Paul and I. Something > to think about. > > (That said, commit lists are not supposed to require moderation anymore, > working with infra to figure out what is going on.) > > Dan > > On Tue June 30 2009 6:55:01 pm Kamaljit Bath wrote: > > Daniel/Paul, > > > > Is this something that you have to do as mentors? Please let me know, > > otherwise I will be happy to send mail to mailing list moderator to allow > > commit messages from me to get sent to the Stonehenge commits list. > > > > Thanks > > kamal > > > > -----Original Message----- > > From: Nandana Mihindukulasooriya [mailto:[email protected]] > > Sent: Saturday, June 27, 2009 2:28 AM > > To: [email protected] > > Subject: Re: No committ mail (was RE: [jira] Updated: (STONEHENGE-55) > > Trying to buy or sell anything an amount larger than 3 digits throws an > > error in .Net stocktrader) > > > > Hi Drew, > > Probably this [1] should be the reason. We will get mails once the > > list moderator approves them. > > > > thanks, > > Nandana > > > > [1] - > > http://www.mail-archive.com/[email protected]/msg00014. > >ht ml > > > > On Sat, Jun 27, 2009 at 12:09 PM, Drew Baird (Volt) > > > > <[email protected]>wrote: > > > Did anyone get commit mail from Kamal? > > > I sync's and got his change but there was never a commit mail? > > > Perhaps there is an infrastructure issue? This is Kamal's first commit. > > > > > > Could a Mentor tell us whether and where to elevate? > > > > > > Thanks! > > > Drew > > > > > > > > > ________________________________________ > > > From: Kamaljit Bath [[email protected]] > > > Sent: Friday, June 26, 2009 2:21 PM > > > To: [email protected] > > > Subject: RE: [jira] Updated: (STONEHENGE-55) Trying to buy or sell > > > anything an amount larger than 3 digits throws an error in .Net > > > stocktrader > > > > > > Ben - I have committed this patch. Please sync and make sure it is ok > > > (I have still not seen the commit mail go by). You can resolve the > > > issue. > > > > > > Kamal > > > > > > -----Original Message----- > > > From: Ben Dewey (JIRA) [mailto:[email protected]] > > > Sent: Thursday, June 25, 2009 9:58 PM > > > To: [email protected] > > > Subject: [jira] Updated: (STONEHENGE-55) Trying to buy or sell anything > > > an amount larger than 3 digits throws an error in .Net stocktrader > > > > > > > > > [ > > > https://issues.apache.org/jira/browse/STONEHENGE-55?page=com.atlassian. > > >ji ra.plugin.system.issuetabpanels:all-tabpanel] > > > > > > Ben Dewey updated STONEHENGE-55: > > > -------------------------------- > > > > > > Attachment: Stonehenge-55-part2.patch > > > > > > Drew, > > > > > > There is an extra part2 to the patch that needs to be applied for it to > > > work. Thanks to avantika for testing and finding this. > > > > > > -Ben > > > > > > > Trying to buy or sell anything an amount larger than 3 digits throws > > > > an > > > > > > error in .Net stocktrader > > > > > > ----------------------------------------------------------------------- > > >-- ------------------------ > > > > > > > Key: STONEHENGE-55 > > > > URL: > > > > https://issues.apache.org/jira/browse/STONEHENGE-55 Project: > > > > Stonehenge Issue Type: Bug > > > > Components: DOTNET_CLIENT > > > > Affects Versions: M1 > > > > Reporter: Chintana Wilamuna > > > > Fix For: M2 > > > > > > > > Attachments: remove-comma.patch, Stonehenge-55-part2.patch, > > > > > > STONEHENGE-55.patch > > > > > > > Steps to reproduce, > > > > 1) Start .Net stocktrader services > > > > 2) Login and try to buy or sell an amount larger than 3 digits > > > > This throws an ASP error. > > > > Cause: If the value the user tries to buy or sell, let's say 1000. > > > > This > > > > > > is represented as "1,000" causing the Integer conversion to fail. > > > > > > > Quick fix: In StockTrade.aspx.cs line 72 and 73 change to the > > > > following, > > > > > > getting rid of the comma: > > > > SellQuantityRangeValidator.MaximumValue = > > > > > > holding.quantity.Replace(",", ""); > > > > > > > SellQuantity.Text = holding.quantity.Replace(",", > > > > > > ""); > > > > > > -- > > > This message is automatically generated by JIRA. > > > - > > > You can reply to this email to add a comment to the issue online. > > > > -- > > Nandana Mihindukulasooriya > > WSO2 inc. > > > > http://nandana83.blogspot.com/ > > http://www.wso2.org -- Daniel Kulp [email protected] http://www.dankulp.com/blog
