On Oct 10, 2006, at 6:51 AM, Remko de Vrijer wrote:

We are having the following issue with the solaris iscsi initiator (yes we know this is the target project....). Whenever we change something on the target, line adding,updating, removing targets or volumes, the following event occurs:

Oct 10 14:02:38 rbgz02 iscsi: [ID 274514 kern.warning] WARNING: iscsi connection(5) login failed - can't accept MaxOutstandingR2T 0

I've done some research and found this in the code:

else if (strcmp(value, "1")) {
                                        cmn_err(CE_WARN, "iscsi connection(%u) "
                                            "login failed - can't accept "
                                            "MaxOutstandingR2T %s",
                                            icp->conn_oid, value);
                                        return (ISCSI_STATUS_NEGO_FAIL);
                                }

the strcmp is incorrect in my opinion since it also returns true in case 'value' == 0, the RFC however states: MaxOutstandingR2T=<numerical-value-from-1-to-65535>.

As you show above 0 is not in the allowable range of 1-to-64k, So returning true is correct. If the target is really sending 0 that would be a bug on the targets side. The initiator only checks for 1 in non-discovery sessions because that is the only value the initiator currently supports.
_______________________________________________
storage-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/storage-discuss

Reply via email to