Here are a few things I noticed.  I won't have time to look at this
more until Jan 2nd.

b2s_tran_setup_pkt always calls getrbuf with KM_SLEEP without
checking whether cb is SLEEP_FUNC or NULL_FUNC.

Rather than treating the CDBs as arrays of bytes, a lot of
these commands have structures and macros defined for them, such
as scsi_inquiry, mode_header, GETG0COUNT, GETG0ADDR, etc.

b2s_scmd_start_stop(): an attempt to send a STOP UNIT command
should bail out at line 1402.

b2s_bus_config's BUS_CONFIG_ONE needs to do more checking of "arg"
since anyone can do "echo < /devices/b2s/foobar"

-  Eric
 
 
This message posted from opensolaris.org
_______________________________________________
storage-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/storage-discuss

Reply via email to