Andrey, I have actually corrected this (removed the #ifdef), forgot to update the webrev. I will update the webrev.
thanks, tim Andrey Kuzmin wrote: >> Date: Fri, 08 Feb 2008 08:48:20 -0700 >> From: tim szeto <[EMAIL PROTECTED]> >> Subject: [storage-discuss] iscsi target code review >> To: [email protected] >> Message-ID: <[EMAIL PROTECTED]> >> Content-Type: text/plain; format=flowed; charset=ISO-8859-1 >> >> I've posted a webrev for the iSCSI Target, comments are appreciated. >> >> The webrev is located at: >> >> http://cr.opensolaris.org/~ts143224/iscsitgtd >> >> > > Looks all right to me except the following: > --- old/usr/src/cmd/iscsi/iscsitgtd/isns_client.c > +++ new/usr/src/cmd/iscsi/iscsitgtd/isns_client.c > 568 569 free(isns_srv); > 569 570 > 571 +#if xxx > 572 + /* let's test if isns-server is valid */ > 573 + if ((so = isns_open(isns_args.server)) < 0) { > 574 + syslog(LOG_ERR, "Fails to get open isns-server %s", > 575 + isns_args.server); > 576 + return (-1); > 577 + } > 578 + isns_close(so); > 579 +#endif > 580 + > 570 581 /* get local hostname for entity usage */ > > If the check for isns server up is essential (hardly), why #ifdef, if > not - why the code is still there? > > Regards, > Andrey > > >> -Tim >> > _______________________________________________ > storage-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/storage-discuss > _______________________________________________ storage-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/storage-discuss
