On Tue, Nov 25, 2008 at 12:34 AM, Peter Buckingham
<[EMAIL PROTECTED]> wrote:
> Hi Cyril,
>
> Cyril Plisko wrote:
>> On Mon, Nov 3, 2008 at 12:00 AM, Cyril Plisko <[EMAIL PROTECTED]> wrote:
>>> On Sun, Nov 2, 2008 at 8:28 PM, Peter Buckingham
>>>> I'd suggest sending the diffs along and we can work through them.
>>>>
>>
>>> the web rev is http://cr.opensolaris.org/~imp/comstar
>>> There are five webrevs there, each successive one is an incremental
>>> against the previous - I have these as different patches in my MQ. Why
>>> is it broken up into 5 patches ? I wanted it to be grouped by the type
>>> of the problem/thing it fixes. I think it will make the review easier.
>>>
>>
>>> Feedback on these patches is greatly appreciated.
>>
>> OK, now what ?
>
> Sorry for the delay. Can you file bugs appropriate to your changes? Then
> we can go the appropriate 'request a sponsor' route.
Done.
6777065 COMSTAR sources should be cstyle clean
6777077 COMSTAR drivers unnecessary NUL-terminate strings
6777085 COMSTAR Makefiles can take advantage of being ON citizens
> On a quick conversation I think they are mostly ok, I think the zalloc
> changes won't be picked up at this stage.
No problem.
>
> thanks again,
>
> peter
>
--
Regards,
Cyril
_______________________________________________
storage-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/storage-discuss
