Hi Kenny The point is that that part of the code has been stable for some time, and AFAIK there have been no reported problems.
Use OpenGrok's 'annotate' feature and you see most of the code in the function 'convert_local_tpgt()' has not changed since when Rick McNeal was working on the code. It must be about two year now since Rick left Sun. http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/cmd/iscsi/iscsitgtd/util.c?a=true Charles made a change recently to the code, but that change should not be available in the binaries until snv_108. But you are using snv_107. So has the code change somehow been released to the binary early, and the new change is causing the problem? Or have you triggred a problem in the 'stable' code? Maybe the root cause of the problem is in some other part of the code, and it just happens to trigger in 'convert_local_tpgt()'. Just looking at the code, I would speculate that maybe something is going wrong in reading the XML configuration data and you are getting a invalid value for an IP address, but note I am NOT an expert on this. I've had an email off-list from Charles and he is asking "Do you have the steps to reproduce this problem?" So Kenny can you just document the steps. I think I can guess them, but just give them 'in your own words' to be sure what your doing. Maybe you could try running that DTrace script in my last post which would just confirm that we are getting to this bit of code with a correct tpgt value. If anyone else reading this is using snv-107 then please try setting up a tpgt and see if it works for you... Regards Nigel Smith -- This message posted from opensolaris.org _______________________________________________ storage-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/storage-discuss
