On 3/31/16 12:34 AM, Jeff Mahoney wrote: > +#include "xlat/btrfs_dev_replace_args.h"
This file was renamed and doesn't exist in a clean build, so I'll at least have to clean that up. I'm also working up test cases for it. One hiccup is that I've used the <name> <value> functionality in the xlat/*.in files to fill in #defines that aren't exported in the version of btrfs.h we're building with. I'd like to just include the xlat/btrfs_*.h files in my test program so we don't need to define them multiple times. The problem there is that the .h files also define the xlat structures, which I don't actually need, and then cause build warnings because they're unused. Do you have a preference on how I handle this? I see 3 options: 1/ Define the macros in multiple places 2/ Teach xlat/gen.sh to produce two .h files. One contains the xlat structures, the other contains the defines. 3/ Teach xlat/gen.sh to wrap the structure definition in a "#ifndef XLAT_DEFINES_ONLY" and allow test programs to define that. My preference is #3 since it means no code change outside of the xlat/gen.sh script. Thanks, -Jeff -- Jeff Mahoney SUSE Labs
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
