On Wed, Apr 20, 2016 at 04:17:22PM +0800, Fei Jie wrote: > diff --git a/tests/getsid.c b/tests/getsid.c > new file mode 100644 > index 0000000..fbe1a56 > --- /dev/null > +++ b/tests/getsid.c > @@ -0,0 +1,23 @@ > +#include "tests.h" > +#include <sys/syscall.h>
sys/syscall.h is not needed
> +#ifdef __NR_getsid
ifdef is not needed
> +# include <stdio.h>
> +# include <unistd.h>
> +
> +int
> +main(void)
> +{
> + pid_t pid = getpid();;
Why ";;"?
> + printf("getsid(%d) = %d\n", pid, getsid(pid));
> +
> + puts("+++ exited with 0 +++");
> + return 0;
> +}
Please indent with TAB.
> +#else
> +
> +SKIP_MAIN_UNDEFINED("__NR_getsid")
> +
> +#endif
This is not needed.
--
ldv
pgpKGhM2IYlIm.pgp
Description: PGP signature
------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
