Re: [PATCH] tests: add signal_receive.test

[Dmitry V. Levin]

On Wed, May 25, 2016 at 03:56:41PM +0800, Fei Jie wrote:
[...]
> diff --git a/tests/signal_receive.c b/tests/signal_receive.c
> new file mode 100644
> index 0000000..73c4ea3
> --- /dev/null
> +++ b/tests/signal_receive.c
> @@ -0,0 +1,67 @@
> +#include "tests.h"
> +#include <signal.h>
> +#include <stdio.h>
> +#include <unistd.h>
> +
> +#if defined ALPHA
> +const char *const signalent[] = {
> +# include "../linux/sparc/signalent.h"
> +};
> +#elif defined HPPA
> +const char *const signalent[] = {
> +# include "../linux/mips/signalent.h"
> +};
> +#elif defined MIPS
> +const char *const signalent[] = {
> +# include "../linux/alpha/signalent.h"
> +};
> +#elif defined SPARC || defined SPARC64
> +const char *const signalent[] = {
> +# include "../linux/hppa/signalent.h"
> +};
> +#else
> +const char *const signalent[] = {
> +# include "../linux/signalent.h"
> +};
> +#endif

These ifdefs shouldn't be needed, plain "signalent.h" should work as well.

If we use signalent.h in the test, we won't be testing signalent.h files,
so I'd rather do without using signalent.h in the test at all.


-- 
ldv

pgpsi3AwLQ3bo.pgp
Description: PGP signature

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel