On Thu, Jan 12, 2017 at 07:13:08PM -0800, Alexey Neyman wrote: > Updated patch attached. > > On 01/12/2017 05:58 PM, Dmitry V. Levin wrote: > >1st, I slightly prefer ioctl_iocdef over ioctls_iocdef. > >2nd, we usually keep intermediate targets. > >3rd, the right way to invoke the preprocessor is $(CPP) with all its > >options. > >4th, sed after grep is a bad shell style. > >5th, let's make "ioctl_iocdef.h" a 100% replacement of <linux/ioctl.h> for > >ioctlsort.c. > Re #5, I thought about it but decided that a clear indication of using > host values would be better. Since you prefer the other way, changed to > remove HOST prefix.
I've added ioctl_iocdef.i to CLEANFILES, added a gnu style changelog entry to the commit message, and merged it. Thanks! -- ldv
pgpN4xvcGai5M.pgp
Description: PGP signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel