> Very sorry for my last reply, actually there are indeed some
> problems here. For syscall who has no arguments such as vfork
> accessing tcp->u_arg here may result an undetermined value.

Oh, that makes sense.  I almost thought this was also a problem
for the existing use of ARG_FLAGS in internal_fork.  But, actually
that code only happens in the exiting case, where setbpt already
ran in the entering case and changed the registers.

> What we want to change only occur in clone syscall, so I think
> we may add one more check here, just like the patch below.
> 
> What do you think?

On ia64, it's clone2.  And there might be others later.
It might be better to test sysent[tcp->scno].sys_func == sys_clone.


Thanks,
Roland

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Strace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/strace-devel

Reply via email to