On Wed, Dec 01, 2010 at 08:02:48AM +0100, Carmelo AMOROSO wrote:
> On 11/30/2010 5:49 PM, Dmitry V. Levin wrote:
> > On Wed, Nov 24, 2010 at 04:12:48PM +0100, Carmelo AMOROSO wrote:
> > [...]
> >> +#ifdef SH
> >> +static const struct xlat cacheflush_flags[] = {
> >> + { CACHEFLUSH_D_INVAL, "CACHEFLUSH_D_INVAL" },
> >> + { CACHEFLUSH_D_WB, "CACHEFLUSH_D_WB" },
> >> + { CACHEFLUSH_D_PURGE, "CACHEFLUSH_D_PURGE" },
> >> + { CACHEFLUSH_I, "CACHEFLUSH_I" },
> >> + { 0, NULL },
> >> +};
> >
>
> > Are you sure these constants are always available?
>
> yes, these are defined in asm/cachectl.h, that is present in sh kernel,
> and always defined.
>
> > Maybe it would be safer to ifdef them like in M68K case?
> >
>
> I don't think it's worth, but if you prefer this way for consistency
> with other arch, I can easily modify the patch.Yes, please add these ifdefs. -- ldv
pgpgaPKeVw9jS.pgp
Description: PGP signature
------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
