On Tue, Feb 22, 2011 at 06:54:38PM -0800, Roland McGrath wrote:
> That looks fine to me.  For the future, I'd be inclined to have any such
> things in 'make check' instead, or perhaps 'make xcheck', and
> conditionalize them on the configured $host_os or perhaps on uname -sr
> results matching "Linux 2.6.*" or something.  There's no reason for
> anything that's just specific to modern Linux to be isolated to only the
> rpm .spec file, where it will only apply to Fedora builds and not Debian
> and any other packaging that others may do.

Agreed.  I've implemented that via "make check":
http://strace.git.sourceforge.net/git/gitweb.cgi?p=strace/strace;a=commitdiff;h=v4.5.20-93-g4e4b5ad
http://strace.git.sourceforge.net/git/gitweb.cgi?p=strace/strace;a=commitdiff;h=v4.5.20-94-g983e875


-- 
ldv

Attachment: pgpfSTvVGJWOL.pgp
Description: PGP signature

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
Strace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/strace-devel

Reply via email to