On 03/16/2011 12:51 AM, Mike Frysinger wrote:
> On Tuesday, March 15, 2011 08:28:40 Vineet Gupta wrote:
>> + }
>> + else {
> there's a few of these in this patch. i think they need to all be:
> } else {
>
>> + memcpy(&sigm, tcp->u_arg + 1, sizeof (sigm));
> no space before that open paren
>
>> +# elif defined(ARC)
>> + int r0;
>> + /* get the sya-call return value */
>> + if (upeek(tcp, PT_r0,&r0)< 0)
>> + return -1;
>> +
>> + /* A signed -ve value doesn't rightaway mean
>> error.
>> + * some calls such as mmap can return high
>> values which if
> treated
>> + * as signed would look like errno. Make sure
>> thats's not
> the case
>> + */
> indentation on that comment block looks like it's too far
>
>> + /* Needed by strace -i to print the PC of syscall trap insn
>> + */
> should be all on one line
> -mike
Fixes incorporated, rebased against master, will send out new patch.
-Vineet
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Strace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/strace-devel
