On 2011-03-14, Dmitry V. Levin <ldv-u2l5PoMzF/[email protected]> wrote: > On Mon, Mar 14, 2011 at 10:47:18AM -0500, Grant Edwards wrote: >> On Sat, Mar 12, 2011 at 03:48:08PM -0600, Grant Edwards wrote: >> >> > Attached are my current diffs. I've merged recent changes from the >> > main git repository and addressed various comments. >> > >> > The notable changes are addition of handling for 'select' syscalls, >> > 'poll' syscalls, and 'epoll_ctl'. >> >> This set of diffs has had a little more cleanup done an code that >> checks paths residing in user-space was re-factored into a separate >> function. > > Thanks. I have two comments after skimming through the patch: > > 1. never use alloca(3) with arbitrary size coming from untrusted input: > it's unsafe, because alloca(3) has no means to indicate a memory > allocation failure; > > 2. getpath() sounds a bit generic, I suggest renaming it to something > more specific, e.g. getfdpath().
Attached are updated diffs against git HEAD as of a few minutes ago... -- Grant
pathtrace.patch
Description: application/patch
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
