On Fri, Jun 03, 2011 at 04:06:51PM +0200, Denys Vlasenko wrote: > I know everybody hates whitespace cleanups, so I rolled mine up > into one big change. This will be less annoying than > gazillion small ones. > > For the review, it is split into two patches. [...] > Dmitry, is it ok with you to apply these?
The changes are OK (as far as I could verify these monotonous cleanups). The main concern with whitespace cleanups is how to enforce a coding style to avoid more whitespace cleanups later. The method we use now is just git diff-index --check, it stops obvious things like trailing whitespace. If we are going to do more advanced cleanup, we should try to apply an appropriate coding style enforcement as well. > If yes, how do you want me to format > commit message? Listing every affected function would create a huge list, > which doesn't seem to be useful to me... Assuming these changes are whitespace only cleanups, I see no use to list every affected function. -- ldv
pgpr414ErQtMR.pgp
Description: PGP signature
------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Discover what all the cheering's about. Get your free trial download today. http://p.sf.net/sfu/quest-dev2dev2
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
