On Tue, Jun 21, 2011 at 03:43:58PM +0200, Denys Vlasenko wrote: > commit dfcd741a5ad170f7fc4ccc0391d3dc92e2d5e3ab > Author: Andi Kleen <[email protected]> > Date: Mon Jun 13 22:05:44 2011 +0000 > > Enhance io_submit() decoding > > strace didn't decode important fields in the iocb passed to io_submit. > This patch changes the code to dump them all. Also it prefixes the fields > with names to make it easier to read. > > * desc.c (iocb_cmd_lookup, print_common_flags): New functions. > (sys_io_submit): New iocb decoder. > > Looks like this commit does not declare struct iocb, > with the following result: > > ... > gcc -DHAVE_CONFIG_H -I. -I./linux/i386 -I./linux -I./linux -Wall > -Wwrite-strings -g -O2 -MT desc.o -MD -MP -MF .deps/desc.Tpo -c -o desc.o > desc.c > desc.c:856:27: warning: ‘struct iocb’ declared inside parameter list [enabled > by default] > desc.c:856:27: warning: its scope is only this definition or declaration, > which is probably not what you want [enabled by default] > desc.c: In function ‘print_common_flags’: > desc.c:858:10: error: dereferencing pointer to incomplete type > desc.c:859:29: error: dereferencing pointer to incomplete type > desc.c:860:10: error: dereferencing pointer to incomplete type > desc.c:861:29: error: dereferencing pointer to incomplete type > desc.c: In function ‘sys_io_submit’: > desc.c:932:2: warning: #warning "libaio-devel is not available => no > io_submit decoding" [-Wcpp] > desc.c: At top level: > desc.c:823:1: warning: ‘iocb_cmd_lookup’ defined but not used > [-Wunused-function] > desc.c:856:1: warning: ‘print_common_flags’ defined but not used > [-Wunused-function] > make[2]: *** [desc.o] Error 1 > make[2]: Leaving directory `/root/srcdevel/strace/fix/strace.t6' > make[1]: *** [all-recursive] Error 1 > make[1]: Leaving directory `/root/srcdevel/strace/fix/strace.t6' > make: *** [all] Error 2
I haven't tested this change in absence of libaio-devel; will fix now. -- ldv
pgpPxltLQHN7i.pgp
Description: PGP signature
------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
