On Tue, Jun 21, 2011 at 08:26:07PM +0200, Denys Vlasenko wrote: > Hi, > > Sometime ago expand_tcbtab/alloc_tcb were modified > so that they never return failure (they will abort instead). > > This opens up a possibility for further simplifications. > > This patch gets rid of fork_tcb() function. It used to do > what the comment above it says, but now it doesn't do much: > it only sets tcp->flags |= TCB_FOLLOWFORK and maybe calls > expand_tcbtab(). The second operation is not necessary, since > alloc_tcp will do it itself when needed. > > This patch deletes fork_tcb, open-coding tcp->flags |= TCB_FOLLOWFORK > where it was formerly called. It also makes nprocs and tcbtabsize > variables static. (While at it, I nuked redundant extern char **environ > declaration: strace.c had *two* of them...) > > Please review.
Looks good. -- ldv
pgpNmcqHnKNwJ.pgp
Description: PGP signature
------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
