On Wed, Mar 14, 2012 at 08:39:35PM -0400, Mike Frysinger wrote: > On Monday 12 March 2012 17:50:48 Dmitry V. Levin wrote: > > - test on supported non-x86 architectures; > > build fails with <=glibc-2.12 because SWAP_FLAG_DISCARD wasn't added until > then. files.c unconditionally uses that.
I had to expect that. Fixed, thanks.
> ia64 has these warnings ... maybe just deleting these defines from the ia64
> header would work ?
> ./linux/ia64/syscallent.h:47:0: warning: "sys_alarm" redefined
> ./linux/dummy.h:114:0: note: this is the location of the previous definition
> ./linux/ia64/syscallent.h:115:0: warning: "sys_getresgid" redefined
> ./linux/dummy.h:73:0: note: this is the location of the previous definition
Fixed, thanks.
> alpha looks broken with signals ... these funcs pass the target's syscall arg
> pointer to the C library's sigprocmask() which obviously won't be valid:
> signal.c: In function ‘sys_sigprocmask’:
> signal.c:1185:3: warning: passing argument 1 of ‘printsigmask’ makes pointer
> from integer without a cast
> signal.c:352:1: note: expected ‘struct sigset_t *’ but argument is of type
> ‘long int’
> signal.c:1188:3: warning: passing argument 2 of ‘sprintsigmask’ makes pointer
> from integer without a cast
> signal.c:283:1: note: expected ‘struct sigset_t *’ but argument is of type
> ‘long int’
The code is in "#ifdef ALPHA" section. Yes, it looks odd, but those lines
remain essentially unchanged since the previous century. Is there anybody
who can look into this?
> ppc64 had a build warning in the syscall code, but i posted a patch to fix
> that.
Applied, thanks.
> then it hit a strict aliasing warning in sys_cap{g,s}et (and looking at
> the code, it does look pretty wrong):
> system.c: In function ‘sys_capset’:
> system.c:559: warning: dereferencing pointer ‘arg0’ does break
> strict-aliasing rules
> system.c:559: warning: dereferencing pointer ‘arg0’ does break
> strict-aliasing rules
> system.c:548: note: initialized from here
This is result of commits v4.6-45-gb0bafbb and v4.6-47-g1c706b3.
I wonder why these warnings appear only on ppc64.
Anyway, I've pushed a fix.
> getting past those, and make compiled cleanly & passed check on:
> alpha ia64 ppc ppc64 s390 s390x x86_64
That's nice, thanks.
--
ldv
pgpce2ul4JWu1.pgp
Description: PGP signature
------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
