On Sat, Mar 30, 2013 at 07:19:50PM -0500, Zev Weiss wrote: > On Mar 30, 2013, at 6:17 PM, Dmitry V. Levin wrote: > > On Fri, Mar 29, 2013 at 03:37:00PM -0500, Zev Weiss wrote: > >> Hello, > >> > >> Current strace prints the offset members of iocb structs passed to > >> io_submit() in hex, which I can't see any particular reason for (it > >> mismatches the normal pread/pwrite format, for one thing), and the > >> additional lack of a leading "0x" prefix makes it unnecessarily difficult > >> to parse. Could the below patch be applied to instead print them in > >> decimal? > > > > Yes, let's change it to match the pread/pwrite output format. > > Would you like to write a commit message? > > > > Sure, hopefully the version below is formatted appropriately... > > Also, I noticed that the rest of the strace codebase uses %d for decimal > integers, so I changed the patch to match (I had initially used %i).
Applied, thanks. -- ldv
pgpxdHLineZ3g.pgp
Description: PGP signature
------------------------------------------------------------------------------ Own the Future-Intel(R) Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
