Add multi-personality support to struct old_sigaction decoding struct sigaction is another structure that contains members whose size differs between 32-bit and 64-bit personalities.
Signed-off-by: Elliott Hughes <[email protected]> On Thu, Feb 27, 2014 at 4:52 PM, enh <[email protected]> wrote: > this fixes decoding of struct sigaction for arm32 binaries traced by > an arm64 strace for me. arm32-arm32 and arm64-arm64 continue to work. > > On Thu, Feb 27, 2014 at 1:45 PM, Dmitry V. Levin <[email protected]> wrote: >> On Thu, Feb 27, 2014 at 11:06:09AM -0800, enh wrote: >>> On Wed, Feb 26, 2014 at 3:42 PM, Dmitry V. Levin <[email protected]> wrote: >>> > I've posted a patch that reimplements signal mask decoding without use of >>> > sigset_t. It fixes this issue, but may introduce new bugs. Please check >>> > whether it builds and passes sigaction.test in your environment. >>> >>> works for me on arm strace tracing an arm binary and arm64 strace >>> tracing an arm64 binary, so please commit. >> >> Thanks. >> >>> (it doesn't work on arm64 when tracing a 32-bit process, but that's a >>> separate issue. do you want me to send you patches in the style of >>> your stack_t patch from yesterday, or do you prefer to write the >>> patches yourself and just want me to let you know when i hit a struct >>> that differs between LP32 and LP64?) >> >> If you've stumbled upon a bug and made a patch that fixes it, please do >> not hesitate and send the fix to this list. Of course I prefer patches >> that are ready to be applied. :) >> >> >> -- >> ldv >> >> ------------------------------------------------------------------------------ >> Flow-based real-time traffic analytics software. Cisco certified tool. >> Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer >> Customize your own dashboards, set traffic alerts and generate reports. >> Network behavioral analysis & security monitoring. All-in-one tool. >> http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk >> _______________________________________________ >> Strace-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/strace-devel >> > > > > -- > Elliott Hughes - http://who/enh - http://jessies.org/~enh/ > Java i18n/JNI/NIO, or bionic questions? Mail me/drop by/add me as a reviewer. -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Java i18n/JNI/NIO, or bionic questions? Mail me/drop by/add me as a reviewer. ------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk _______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
