On Tue 04 Mar 2014 17:41:27 William Manley wrote: > +static void print_v4l2_format(const struct v4l2_format* fmt)
the spacing is incorrect around the *:
static void print_v4l2_format(const struct v4l2_format *fmt)
> +{
> + tprintf("type=");
> + printxval(v4l2_formats, fmt->type, "V4L2_BUF_TYPE_???");
> + tprintf(", fmt={");
> + switch (fmt->type) {
> + case V4L2_BUF_TYPE_VIDEO_CAPTURE:
i think our style says the case should be same indentation as the switch.
especially for large funcs like this, it helps with over-indentation and
staves off excessive wrapping.
switch (fmt->type) {
case V4L2_BUF_TYPE_VIDEO_CAPTURE:
> + case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE :
> + case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE :
> + {
style issue: no space before the colon, and the brace should be cuddled up.
case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE: {
> + break;
> + default:
blank line above the default
> + for (n=0; n<c.count; ++n) {
needs spacing around ops:
for (n = 0; n < c.count; ++n) {
> + umove(tcp, (long) (c.controls + n), &ctrl);
is that cast really needed ? i suspect not.
> + }
> + else {
we've been inconsistent, but i prefer this being one line:
} else {
> + switch (f.type)
> + {
cuddle that brace
-mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
