On Thu 20 Mar 2014 19:15:35 Dmitry V. Levin wrote: > On Thu, Mar 20, 2014 at 01:59:05AM -0400, Mike Frysinger wrote: > > On Thu 20 Mar 2014 01:51:30 Dmitry V. Levin wrote: > > > strace on ARM EABI currently implements limited OABI support. > > > This feature is enabled by default, and it costs extra PTRACE_PEEKTEXT > > > on > > > every syscall. > > > > > > I wonder whether OABI is used on some ARM EABI systems nowadays? > > > Wouldn't it be better to disable this feature by default? > > > > i wouldn't mind putting it behind a compile time flag, but i'm not sure > > about dropping it. i still see OABI binaries about :/. > > http://sourceforge.net/p/strace/code/ci/0a03dde091e828ead824d4ff2f95882264fb > 37f4/ - would it be OK?
seems like the defined() check is redundant since you explicitly always define it, but otherwise, LGTM -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
