On Thu, Apr 10, 2014 at 01:52:11AM +0900, Masatake YAMATO wrote: > Signed-off-by: Masatake YAMATO <[email protected]> > --- > unwind.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/unwind.c b/unwind.c > index a7e985e..0f9f79d 100644 > --- a/unwind.c > +++ b/unwind.c > @@ -130,6 +130,7 @@ build_mmap_cache(struct tcb *tcp) > char filename[sizeof ("/proc/0123456789/maps")]; > char buffer[PATH_MAX + 80]; > char binary_path[PATH_MAX]; > + size_t blen; > struct mmap_cache_t *cur_entry, *prev_entry; > /* start with a small dynamically-allocated array and then expand it */ > size_t cur_array_size = 10; > @@ -162,6 +163,11 @@ build_mmap_cache(struct tcb *tcp) > if (binary_path[0] == '\0') > continue; > > + /* ignore deleted file. */ > + blen = strlen(binary_path); > + if (blen >= 10 && strcmp(binary_path + blen - 10, " (deleted)") > == 0) > + continue; > +
First of all, please do not hardcode magic numbers.
If you mean strlen("(deleted)"), just write it.
Second, why deleted files should be excluded from stack trace?
--
ldv
pgpHqM2ST2v_4.pgp
Description: PGP signature
------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
