On Wed, Apr 16, 2014 at 11:19:06PM -0700, Dima Kogan wrote: > Dima Kogan <[email protected]> writes: > > Dmitry V. Levin <[email protected]> writes: > > > >> Unfortunately, your patch breaks all 64-bit architectures because offset > >> is passed as a single argument > > > > Oh yeah. I clearly broke that; sorry about that. We want to parse preadv > > and pwritev in exactly the same way we parse llseek. That syscall does > > the same arg splitting. Its code looks very similar, so after 30 seconds > > of looking at it I'm not yet sure why that works. I'll look more closely > > later tonight. > > OK. Never mind on the llseek, actually. I was testing lseek, NOT llseek, > which is why it looked odd. The patch I attached earlier can be fixed > with some #ifdefs probably. I should be pretty trivial. Is it useful for > me to do it, or do you want to?
If the result is going to be as complex as printllval without alignment, it worth extending printllval instead of reinventing the wheel. -- ldv
pgpM_yq1KSAlM.pgp
Description: PGP signature
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
