On Tue, Dec 09, 2014 at 12:33:23PM +0900, Masatake YAMATO wrote: > BTW, > > > * linux/unix_diag.h: New file. > > * linux/rtnetlink.h: New file. > > Should I bundle linux/unix_diag.h and linux/rtnetlink.h in > my changes? (I included the shrunk version of them in my changes.) > > I'm not sure the criteria which .h files are included in strace > or not.
The tradition to bundle stripped-down editions of linux/ .h files is quite recent, the idea behind it was to reduce the number of autoconf tests and ifdefs in the code. I'm not sure this was well thought out, though, because we've got several GPLv2-only header files in the project which is distributed under the BSD-style 3-clause license, which is not compatible with GPL because of that advertising clause. That is, do not bundle drop-in replacements of linux/ .h files if you can avoid it. What you need from <linux/rtnetlink.h> is essentially unchanged for more than 10 years, so you can safely include it. The constants you use from <linux/unix_diag.h> were not all available before v3.3, so more care should be taken. -- ldv
pgpmpK9KT7Jt6.pgp
Description: PGP signature
------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
