On Tue, Mar 17, 2015 at 06:49:31PM -0400, Mike Frysinger wrote: > On 17 Mar 2015 15:18, Dmitry V. Levin wrote: > > On Tue, Mar 17, 2015 at 03:36:55AM -0400, Mike Frysinger wrote: > > > On 16 Mar 2015 21:42, Felix Janda wrote: > > > > <asm/ioctl.h> is for example needed for _IOC_SIZE(). That is > > > > likely also the reason why ioctl.c includes it. > > > > evdev.c includes <linux/input.h> which includes <sys/ioctl.h>. > > On glibc, this leads to inclusion of <asm/ioctl.h>, musl may do things > > differently. > > > > > we should stick to linux/ioctl.h imo, and update ioctl.c to match > > > > I'm OK with including <asm/ioctl.h>; <linux/ioctl.h> includes other > > headers besides <asm/ioctl.h>. > > i think generally we should be sticking to linux/xxx.h unless we specifically > need something out of asm/xxx.h. although i'm not sure what you mean in this > case ... > > $ cat include/uapi/linux/ioctl.h > #ifndef _LINUX_IOCTL_H > #define _LINUX_IOCTL_H > > #include <asm/ioctl.h> > > #endif /* _LINUX_IOCTL_H */
I must have confused it with <sys/ioctl.h>; that one certainly includes other headers. :) Now I'm fine with replacing <asm/ioctl.h> with <linux/ioctl.h>. -- ldv
pgpycV_PBe40W.pgp
Description: PGP signature
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
