On Wed, Aug 19, 2015 at 01:26:56PM -0400, Mike Frysinger wrote: > On 19 Aug 2015 18:56, Dmitry V. Levin wrote: > > On Tue, Aug 18, 2015 at 05:03:20PM -0400, Mike Frysinger wrote: > > [...] > > > * util.c (printxval): Rename to ... > > > (printxvals): ... this. Rewrite to be varargs based. > > > * xlat/getsockipoptions.in: New xlat list. > > > * xlat/getsockipv6options.in, xlat/setsockipoptions.in, > > > xlat/setsockipv6options.in: Likewise. > > > --- > > > RFC: i'm not terribly happy with the printxvals logic. open to > > > suggestions. > > > > What's it in the printxvals logic that doesn't make you happy? > > using varargs all the time when the previous code was just a simple func. > seems like it's adding a good amount of overhead. maybe i'm pessimistic > as i haven't done any perf checks.
We can have two separate functions, it's not a big deal. -- ldv
pgpttFux_rawT.pgp
Description: PGP signature
------------------------------------------------------------------------------
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
