On Thu, Mar 24, 2016 at 10:40:39AM +0800, Wei Yulan wrote: > > > 在 2016年3月23日，下午11:51，Dmitry V. Levin <[email protected]> 写道： > > > > On Wed, Mar 23, 2016 at 08:17:07PM +0800, 魏宇蓝 wrote: > >> Hi all, > >> > >> I am new to here, and I am reading the codebase today. Here is something I > >> found made me confused. > >> > >> After built all test cases, I run this commands following: > >> > >> [vagrant@localhost:~/strace-code/tests ]$ touch rename_old > > > > What do you mean by creating this file? > > > Thanks for your reply. > > As we known, it can be divided into two situations when calling rename. One > is rename a exist file. Another is rename a non-exist file. > > I try to create a empty file to test the former situation, but the real > output is not same as expected output. In rename.test, it test the latter > situation only. Should we consider the former situation for rename.test?
rename.test assumes that file named rename_old does not exist because nothing in the test suite creates a file with this name. Why do you create a file with the name that is expected not to exist? -- ldv
pgplHWGCk3EeX.pgp
Description: PGP signature
------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
