On Fri, Apr 22, 2016 at 3:38 AM, Dmitry V. Levin <l...@altlinux.org> wrote:
> On Thu, Nov 26, 2015 at 02:40:31PM +0100, Patrik Jakobsson wrote:
>> On Tue, Nov 24, 2015 at 6:46 AM, Dmitry V. Levin wrote:
>> > On Mon, Sep 07, 2015 at 08:23:57PM +0200, Patrik Jakobsson wrote:
>> >> On Mon, Sep 7, 2015 at 6:51 PM, Dmitry V. Levin wrote:
>> >> > On Mon, Aug 31, 2015 at 02:37:07PM +0200, Patrik Jakobsson wrote:
>> >> > [...]
>> >> >> Here's my take on it (I assume it needs some discussion):
>> >> >>
>> >> >> int
>> >> >> set_tcb_priv_data(struct tcb *tcp, void *priv_data)
>> >> >> {
>> >> >> /* A free callback is required before setting private data and
>> >> >> private
>> >> >> * data must be set back to NULL before being set again.
>> >> >> */
>> >> >
>> >> > I think a single function initializing both _priv_data and
>> >> > _free_priv_data
>> >> > would suffice:
>> >> >
>> >> > int
>> >> > set_tcb_priv_data(struct tcb *tcp, void *priv_data,
>> >> > void (*free_priv_data)(void *))
>> >> > {
>> >> > if (tcp->_priv_data)
>> >> > return -1;
>> >> >
>> >> > tcp->_free_priv_data = free_priv_data;
>> >> > tcp->_priv_data = priv_data;
>> >> >
>> >> > return 0;
>> >> > }
>> >>
>> >> Sure, and since they always come in a pairs it might be even better. If
>> >> it turns
>> >> out we need it split up it is easily done later.
>> >
>> > The discussion seems to be stalled.
>> > Patrik, would you like to prepare a patch?
>>
>> Hi Dmitry
>>
>> I'll send you new patches this weekend. Thanks for reminding me.
>
> Hi Patrik,
>
> Is there any progress with this patch series?
Hi Dmitry
This unfortunately ended up at the bottom of my todo list. Let's see
if I can flip the list in the coming days.
Thanks
Patrik
>
>
> --
> ldv
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel
