On Mon, May 09, 2016 at 10:44:06AM +0100, Dr. David Alan Gilbert wrote: > * Dmitry V. Levin (l...@altlinux.org) wrote: > > On Fri, May 06, 2016 at 12:11:08PM +0100, Dr. David Alan Gilbert wrote: > > [...] > > > Thanks; I've just posted a set on top of that; note that > > > one thing is that for 64bit it's still not quite > > > right since the gen.sh generates 1<<CONSTANT rather than 1ull<<CONSTANT > > > > Values generated by gen.sh seems to be correct (1ULL<<CONSTANT), > > it's strace output that's going to be "1<<CONSTANT". > > Do you suggest to change the output string, too? > > It is the output string I meant; I don't really care that much about it, > although it's not correct from it being valid C with that big a shift.
I see. At the same time,
ioctls=1ull<<_UFFDIO_REGISTER|1ull<<_UFFDIO_UNREGISTER|1ull<<_UFFDIO_API
would look even more bulky than current
ioctls=1<<_UFFDIO_REGISTER|1<<_UFFDIO_UNREGISTER|1<<_UFFDIO_API
and compiler will warn if one tries to use this big shift literally.
I'd rather sacrifice strict C correctness for readability
and leave this as it is now.
--
ldv
pgppPF1SFebXM.pgp
Description: PGP signature
------------------------------------------------------------------------------ Mobile security can be enabling, not merely restricting. Employees who bring their own devices (BYOD) to work are irked by the imposition of MDM restrictions. Mobile Device Manager Plus allows you to control only the apps on BYO-devices by containerizing them, leaving personal data untouched! https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
