On Fri, Jun 17, 2016 at 04:29:56PM +0000, Fabien Siron wrote:
[...]
> + const void *const efault = tail_alloc(sizeof(struct nlmsghdr) - 1);
[...]
> + sendto(fd, efault, sizeof(struct nlmsghdr), MSG_DONTWAIT, NULL, 0);
> +
> + printf("sendto(%d, %#lx, %u, MSG_DONTWAIT, NULL, 0) = -1 "
> + "EFAULT (Bad address)\n", fd, (unsigned long) efault,
> + (unsigned) sizeof(struct nlmsghdr));efault is a pointer; the natural format of printing pointers is %p. No need to print "Bad address" verbatim, use %m format string instead. [...] > +++ b/tests/netlink_parsing.test > @@ -0,0 +1,48 @@ > +#!/bin/sh > +# > +# Check decoding of protocol:portid pairs associated with socket > +# descriptors This comment has to be updated. [...] > +# strace -yy is implemented using /proc/self/fd > +[ -d /proc/self/fd/ ] || > + framework_skip_ '/proc/self/fd/ is not available' As the test doesn't use -yy feature, this check is not needed. -- ldv
pgpXC13y3JVtb.pgp
Description: PGP signature
------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohomanageengine
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
