Hi,

On Wed, Jul 27, 2016 at 08:41:14PM +0200, Nahim El Atmani wrote:
> From: Nahim El Atmani <n...@lse.epita.fr>
> 
> From: Nahim El Atmani <nahim+...@naam.me>

Could you choose just one "From"?

> * util.c (string_to_int): New function.

This would be OK if subsequent patches would use it.
Apparently, they don't: in the only place where string_to_int is called
the string starts with a digit so string_to_uint is enough.

> * defs.h: Add it.

This would have to be
* defs.h (string_to_int): New prototype.


-- 
ldv

Attachment: pgpBR22s6snoi.pgp
Description: PGP signature

------------------------------------------------------------------------------
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel

Reply via email to