On Fri, Jul 29, 2016 at 03:06:50PM +0200, Gabriel Laskar wrote: > On Fri, 29 Jul 2016 04:04:02 +0300, Dmitry V. Levin wrote: > > On Wed, Jul 27, 2016 at 08:41:16PM +0200, Nahim El Atmani wrote: [...] > > > new configure flag have been created (--enable-fault-injection) > > > to keep the build clean on other architectures. > > > > Please don't make this option configurable. It complicates the code > > (== causes mistakes) and gives very little in return. > > The goal here was to enable the feature only for architecture where > this was really tested, mainly in order to validate the model, and > after, enable it without an option, when properly tested on all > architectures.
If these arch-specific functions are difficult to implement, let's re-use the approach taken by arch_sigreturn. However, all arch specific details are well known so I think this is not going to be as difficult as arch_sigreturn. > > > * There is still one TODO left which is supporting the fuzzy > > > approach using percentage as an occurrence. It should comes soon > > > since all the option parsing is done. On that note fuzzing means we > > > want to be able to reproduce, so we have to keep the seed somewhere > > > and take it as an input. I my opinion using the environment for > > > this kind of things is better than adding a new option, what do you > > > think? > > > > Using environment is OK. > > Something like STRACE_SEED should be ok? If this is specific to fault injection, let's use a more specific name, e.g. STRACE_FAULT_INJECTION_SEED. A more generic name like STRACE_SEED is OK if this is going to be used elsewhere in strace. -- ldv
pgprmnuD2ycMy.pgp
Description: PGP signature
------------------------------------------------------------------------------
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
