.
On Sun, Mar 5, 2017 at 8:48 AM, Dmitry V. Levin <l...@altlinux.org> wrote:
> Hi,
>
> On Sun, Mar 05, 2017 at 01:54:33AM +0530, Abhishek Tiwari wrote:
>> On Sat, Mar 4, 2017 at 5:41 PM, Abhishek Tiwari
>> <erabhishektiwar...@gmail.com> wrote:
>> > Good evening everyone,
>> > I am Abhishek Tiwari pursuing M.Tech IIT Kharagpur. I am looking
>> > forward to contribute to strace Project Idea -> Netlink socket
>> > parsers.
>> >
>> > Thank you.
>>
>> I have made a change in INSTALL file (there the bootstrap script was
>> not mentioned to be run in installation step). Please review the
>> patch.
>
> This INSTALL file comes directly from GNU Automake, it's intended
> for those who build the package from tarball.
>
> To build strace "from git", one has to run ./bootstrap script first.
> This is mentioned in README-hacking, but not in INSTALL file,
> which is somewhat confusing.
>
> Perhaps it would be better to create a separate file with instructions how
> to build strace "from git" and reference INSTALL from there.
>
> Alternatively, we can modify INSTALL file, but the new wording shouldn't
> be confusing to those who build strace from tarball.
>
>> Is sending patch preferred over sending pull request or I can directly
>> send pull requests from github?
>
> We prefer patches sent to this mailing list.
>
>
> --
> ldv
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Strace-devel mailing list
> Strace-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/strace-devel
>
Thank you ldv for your response
I have made changes to README.md file so that instruction would be
visible as anyone visits the repository on Github.
Below is patch attached for the same.
From 3efa467b5a611d8dc34270ddacf6caf31549cba2 Mon Sep 17 00:00:00 2001
From: Abhishek Tiwari <erabhishektiwar...@gmail.com>
Date: Sun, 5 Mar 2017 18:16:14 +0530
Subject: [PATCH v2] Updated README.md file for building strace source code
from git version
---
README.md | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/README.md b/README.md
index 35663a1..0384fc2 100644
--- a/README.md
+++ b/README.md
@@ -7,3 +7,16 @@ See the file [NEWS](https://raw.githubusercontent.com/strace/strace/master/NEWS)
Please send bug reports and enhancements to [the strace mailing list](https://lists.sourceforge.net/lists/listinfo/strace-devel).
[](https://travis-ci.org/strace/strace) [](https://codecov.io/github/strace/strace?branch=master)
+
+INSTALLATION GUIDELINES
+========================
+
+1. Install using tarball
+--------------------------
+
+To install `strace` using tarball run GNU Automake command and follow instructions given in `INSTALL` file.
+
+2. Build using git
+---------------------
+
+To build strace source code downloaded from git repository, first run `./bootstrap` script and then follow the guidelines given in `INSTALL` file.
--
2.7.4
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel
