On Fri, Mar 17, 2017 at 06:35:09PM +0100, Eugene Syromyatnikov wrote:
> Please format function declaration as following:
> 
> int
> nsfs_ioctl(struct tcb *tcp, unsigned int code, kernel_ulong_t arg) {
Oops. Opening curly brace should be on the next line, like this:

int
nsfs_ioctl(struct tcb *tcp, unsigned int code, kernel_ulong_t arg)
{

>       if (!umove_or_printaddr(tcp, arg, &uid)) {
>               printuid(", [", uid);
>               tprints("]");
>       }
Ahem. I forgot that the comma should be also printed in case of address
printing too, so it should be written like this:

        tprints(", ")
        if (!umove_or_printaddr(tcp, arg, &uid)) {
                printuid("[", uid);
                tprints("]");
        }

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel

Reply via email to