>> git grep -Fl 'statfs' linux/*/syscallent* | xargs sed -i
>> 's/0\(,[[:space:]]*SEN(osf_statfs\)/TSF\1/'
>> git grep -Fl 'statfs' linux/*/syscallent* | xargs sed -i
>> 's/0\(,[[:space:]]*SEN(.*_statfs\)/TSF\1/'
>> git grep -Fl 'statvfs' linux/*/syscallent* | xargs sed -i
>> 's/0\(,[[:space:]]*SEN(.*_statvfs\)/TSF\1/'
>
> Why do you need 3 commands where a single command would suffice?
>
> Why these entries don't have TF flag set in the first place?
> It's a bug that should be fixed with a separate commit.
>
I have added TF flag to osf_statfs, osf_statfs64, posix_statfs,
bsd43_statfs, sysv_statfs, sysv_statvfs, svr4_statfs, svr4_statvfs
which don't have TF flag set.
Below is patch attached for the same.
None of stat related syscalls have their corresponding flag set.
$ grep -nr '_\(\|f\|l\)stat' linux/*/syscallent*
Should these be updated with their corresponding tags ?
fstatfs*-> TD
lstat*-> TD
{,old_}stat*-> TF
or are they intensional?
sorry for redundancy. Will fix other too.
>
> --
> ldv
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Strace-devel mailing list
> Strace-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/strace-devel
>
From c12a70031d8c3d390712c3cf3c811bc775b4eb37 Mon Sep 17 00:00:00 2001
From: Abhishek Tiwari <erabhishektiwar...@gmail.com>
Date: Sun, 19 Mar 2017 10:18:48 +0530
Subject: [PATCH v1] Fixed bug by adding TF flag to statfs and statvfs
Following command fixed the bug:
git grep -Fl 'statfs' linux/*/syscallent* | xargs sed -i \
's/0\(,[[:space:]]*SEN(.*_stat\(\|v\)fs\)/TF\1/'
* linux/alpha/syscallent.h: Added TF flag to statfs and statvfs syscalls
* linux/mips/syscallent-compat.h: Likewise.
---
linux/alpha/syscallent.h | 4 ++--
linux/mips/syscallent-compat.h | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/linux/alpha/syscallent.h b/linux/alpha/syscallent.h
index 4449f22..acec527 100644
--- a/linux/alpha/syscallent.h
+++ b/linux/alpha/syscallent.h
@@ -185,7 +185,7 @@
[157] = { 5, 0, SEN(printargs), "osf_sigwaitprim" }, /*not implemented */
[158] = { 5, 0, SEN(printargs), "osf_nfssvc" }, /*not implemented */
[159] = { 4, 0, SEN(printargs), "osf_getdirentries" },
-[160] = { 3, 0, SEN(osf_statfs), "osf_statfs" },
+[160] = { 3, TF, SEN(osf_statfs), "osf_statfs" },
[161] = { 3, 0, SEN(osf_fstatfs), "osf_fstatfs" },
[162] = { },
[163] = { 5, 0, SEN(printargs), "osf_asynch_daemon" }, /*not implemented */
@@ -230,7 +230,7 @@
[224] = { 5, 0, SEN(printargs), "osf_stat" }, /*not implemented */
[225] = { 5, 0, SEN(printargs), "osf_lstat" }, /*not implemented */
[226] = { 5, 0, SEN(printargs), "osf_fstat" }, /*not implemented */
-[227] = { 3, 0, SEN(osf_statfs), "osf_statfs64" }, /*not implemented */
+[227] = { 3, TF, SEN(osf_statfs), "osf_statfs64" }, /*not implemented */
[228] = { 3, 0, SEN(osf_fstatfs), "osf_fstatfs64" }, /*not implemented */
[229 ... 232] = { },
[233] = { 1, 0, SEN(getpgid), "getpgid" },
diff --git a/linux/mips/syscallent-compat.h b/linux/mips/syscallent-compat.h
index 82a373b..9113f96 100644
--- a/linux/mips/syscallent-compat.h
+++ b/linux/mips/syscallent-compat.h
@@ -33,7 +33,7 @@
[ 32] = { 0, 0, SEN(printargs), "svr4_gtty" },
[ 33] = { 0, 0, SEN(printargs), "svr4_access" },
[ 34] = { 0, 0, SEN(printargs), "svr4_nice" },
-[ 35] = { 0, 0, SEN(printargs), "svr4_statfs" },
+[ 35] = { 0, TF, SEN(printargs), "svr4_statfs" },
[ 36] = { 0, 0, SEN(printargs), "svr4_sync" },
[ 37] = { 0, 0, SEN(printargs), "svr4_kill" },
[ 38] = { 0, 0, SEN(printargs), "svr4_fstatfs" },
@@ -96,7 +96,7 @@
[ 100] = { 0, 0, SEN(printargs), "svr4_setcontext" },
[ 101] = { 0, 0, SEN(printargs), "svr4_evsys" },
[ 102] = { 0, 0, SEN(printargs), "svr4_evtrapret" },
-[ 103] = { 0, 0, SEN(printargs), "svr4_statvfs" },
+[ 103] = { 0, TF, SEN(printargs), "svr4_statvfs" },
[ 104] = { 0, 0, SEN(printargs), "svr4_fstatvfs" },
[ 105] = { },
[ 106] = { 0, 0, SEN(printargs), "svr4_nfssys" },
@@ -184,7 +184,7 @@
[1032] = { 0, 0, SEN(printargs), "sysv_gtty" },
[1033] = { 0, 0, SEN(printargs), "sysv_access" },
[1034] = { 0, 0, SEN(printargs), "sysv_nice" },
-[1035] = { 0, 0, SEN(printargs), "sysv_statfs" },
+[1035] = { 0, TF, SEN(printargs), "sysv_statfs" },
[1036] = { 0, 0, SEN(printargs), "sysv_sync" },
[1037] = { 0, 0, SEN(printargs), "sysv_kill" },
[1038] = { 0, 0, SEN(printargs), "sysv_fstatfs" },
@@ -318,7 +318,7 @@
[1171] = { 0, 0, SEN(printargs), "sysv_sigstack" },
[1172] = { 0, 0, SEN(printargs), "sysv_sigaltstack" },
[1173] = { 0, 0, SEN(printargs), "sysv_sigsendset" },
-[1174] = { 0, 0, SEN(printargs), "sysv_statvfs" },
+[1174] = { 0, TF, SEN(printargs), "sysv_statvfs" },
[1175] = { 0, 0, SEN(printargs), "sysv_fstatvfs" },
[1176] = { 0, 0, SEN(printargs), "sysv_getpmsg" },
[1177] = { 0, 0, SEN(printargs), "sysv_putpmsg" },
@@ -494,7 +494,7 @@
[2157] = { 0, 0, SEN(printargs), "bsd43_nfs_mount" },
[2158] = { 0, 0, SEN(printargs), "bsd43_nfs_svc" },
[2159] = { 0, 0, SEN(printargs), "bsd43_getdirentries" },
-[2160] = { 0, 0, SEN(printargs), "bsd43_statfs" },
+[2160] = { 0, TF, SEN(printargs), "bsd43_statfs" },
[2161] = { 0, 0, SEN(printargs), "bsd43_fstatfs" },
[2162] = { 0, 0, SEN(printargs), "bsd43_unmount" },
[2163] = { 0, 0, SEN(printargs), "bsd43_async_daemon" },
@@ -562,7 +562,7 @@
[3032] = { 0, 0, SEN(printargs), "posix_gtty" },
[3033] = { 0, 0, SEN(printargs), "posix_access" },
[3034] = { 0, 0, SEN(printargs), "posix_nice" },
-[3035] = { 0, 0, SEN(printargs), "posix_statfs" },
+[3035] = { 0, TF, SEN(printargs), "posix_statfs" },
[3036] = { 0, 0, SEN(printargs), "posix_sync" },
[3037] = { 0, 0, SEN(printargs), "posix_kill" },
[3038] = { 0, 0, SEN(printargs), "posix_fstatfs" },
--
2.7.4
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel
