On Thu, Apr 13, 2017 at 06:58:00PM +0300, Dmitry V. Levin wrote:
> On Thu, Apr 13, 2017 at 10:10:11PM +0700, Nikolay Marchuk wrote:
> [...]
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -19,6 +19,7 @@ Noteworthy changes in release ?.?? (????-??-??)
> > architectures.
> > * Implemented decoding of statx syscall.
> > * Updated lists of ioctl commands from Linux 4.11.
> > + * Implemented decoding of NS_* ioctl commands.
>
> I prefer "Implemented" news to be listed before "Updated".
>
> [...]
> > +static void
> > +test_user_namespace(void)
> > +{
> > + pid_t pid;
> > + int pipefd[2];
> > + int rc, status;
> > +
> > + rc = pipe(pipefd);
> > + if (rc == -1)
> > + perror_msg_and_fail("pipe");
>
> I don't see why do you need rc here, the same could be written as
>
> if (pipe(pipefd))
> perror_msg_and_fail("pipe");
>
> > + pid = clone(child, tail_alloc(1) + 1,
> > + CLONE_NEWUSER | CLONE_UNTRACED | SIGCHLD, pipefd);
> > + if (pid == -1) {
> > + perror("clone");
> > + return;
> > + }
> > + close(pipefd[0]);
> > + test_clone(pid);
> > + close(pipefd[1]);
> > + if (wait(&status) != pid) {
> > + perror_msg_and_fail("wait");
> > + } else if (status != 0){
>
> Please put a space between ) and {.OK, I've applied these trivial changes myself and pushed it. Thanks! -- ldv
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
