On Mon, Apr 17, 2017 at 9:40 PM, Dmitry V. Levin wrote:
>On Wed, Mar 29, 2017 at 05:39:59PM +0800, JingPiao Chen wrote:
>> I updated the patch[1] and the proposal draft[2].
>> Please provide some feedback.
>> [1]https://github.com/ppiao/strace/tree/nl-socket
>
>As I said, every logically separate change must go to an individual commit,
>the way Fabien did in his branch. You can rebase/fix/whatever commits
>made by Fabien, but please don't squash them -- nobody is going to spend
>time on a squashed netlink branch.
>
>I've just pushed several netlink related commits to master, you can review
>them and use as examples of commit separation, too.
Thank you for your reply. I have read the code.
>Note that at least some of commits in netlink branch contain bugs,
>including design bugs. For example, the first commit "Add support for
>NLMSG_ERROR and NLMSG_DONE" stops netlink processing when NLMSG_ERROR
>or NLMSG_DONE is encountered, which is incorrect.
--
JingPiao Chen
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel
