On Tue, Jun 27, 2017 at 06:10:07PM +0800, JingPiao Chen wrote: [...] > --- a/nlattr.c > +++ b/nlattr.c > @@ -29,6 +29,7 @@ > > #include "defs.h" > #include "netlink.h" > +#include "nlattr.h" > > static bool > fetch_nlattr(struct tcb *const tcp, struct nlattr *const nlattr, > @@ -65,7 +66,10 @@ decode_nlattr_with_data(struct tcb *tcp, > kernel_ulong_t addr, > kernel_ulong_t len, > const struct xlat *const table, > - const char *const dflt) > + const char *const dflt, > + const nla_decoder_t *decoders, > + unsigned int size, > + void *const opaque_data)
I tend to add "const" qualifier to auto variables and function arguments, despite it doesn't affect the code generated by the compiler. The purpose of this "const" qualifier is to highlight the intent. Some people find this use of "const" qualifier redundant, though. -- ldv
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel