On Thu, Jul 06, 2017 at 09:57:28AM +0800, JingPiao Chen wrote:
> * nlattr.c (decode_nlattr_with_data): Replace printstrn
> with printstr_ex and set QUOTE_FORCE_HEX flag.

Perhaps in other cases of netlink decoder where printstrn is used
(except decode_nla_strn) QUOTE_FORCE_HEX is more appropriate, too.

$ grep printstrn netlink.c netlink_sock_diag.c nlattr.c
netlink.c:              printstrn(tcp, addr, len);
netlink.c:              printstrn(tcp, addr, len);
netlink.c:      printstrn(tcp, addr, len);
netlink_sock_diag.c:            printstrn(tcp, addr + sizeof(family),
nlattr.c:               printstrn(tcp, addr, len);
nlattr.c:                       printstrn(tcp, addr + NLA_HDRLEN, len - 
NLA_HDRLEN);
nlattr.c:       printstrn(tcp, addr, len);

You don't have to squash all these changes into a single commit, though.


-- 
ldv

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel

Reply via email to