On 07.08.2017 11:52, Eugene Syromiatnikov wrote:
> What makes incredibly difficult to review this patch is the abundance of
> all these syscall sets.  I think, making return code of
> match_fd_common/pathtrace_match_state tri-state (positive match,
> negative match, no match) instead of boolean could significantly
> simplify the code and avoid the duplication in run_fd_filter and
> pathtrace_match_set.

I had already tried to made tri-state implementation of match_fd_common,
but in my implementation match_fd_common had additional
responsibilities from pathtrace_match_set and code didn't become simpler.
I have no idea what states should I choose to simplify code.

> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Strace-devel mailing list
> Strace-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/strace-devel
>

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel

Reply via email to